Discussion:
Robert C. Martin Where is the Foreman
Scott Shipp
2014-03-07 18:55:14 UTC
Permalink
Has anyone seen the "Where is the foreman?" blog posts from Robert C. Martin lately. What are your opinions about the idea that one person or a small oligarchy should vet all code commits? Does anyone work in a situation where this is actually the case? What is the experience like?

References:
Initial Post: http://blog.8thlight.com/uncle-bob/2014/02/21/WhereIsTheForeman.html
Followup: http://blog.8thlight.com/uncle-bob/2014/02/23/OhForemanWhereArtThou.html
Followup2: http://blog.8thlight.com/uncle-bob/2014/02/27/TheTrustSpectrum.html
Joe Bowbeer
2014-03-07 19:18:22 UTC
Permalink
I agree that crappy code is widespread (especially regarding thread-safe
aspects and extensible construction). If the missing knowledge is
widespread in a team then things aren't going to improve, and furthermore,
any heroic efforts by consultants will quickly be worn away. So I can
certainly sympathize with the "where is the foreman" question. I think it's
a legitimate question to ask. If a team isn't producing the quality of code
that it needs to produce then some changes need to be made. A foreman or
gatekeeper is one approach.
Post by Scott Shipp
Has anyone seen the "Where is the foreman?" blog posts from Robert C.
Martin lately. What are your opinions about the idea that one person or a
small oligarchy should vet all code commits? Does anyone work in a
situation where this is actually the case? What is the experience like?
http://blog.8thlight.com/uncle-bob/2014/02/21/WhereIsTheForeman.html
http://blog.8thlight.com/uncle-bob/2014/02/23/OhForemanWhereArtThou.html
http://blog.8thlight.com/uncle-bob/2014/02/27/TheTrustSpectrum.html
Richard Rodseth
2014-03-07 22:04:52 UTC
Permalink
At my workplace the commit comment is supposed to reference the person who
reviewed the commit. It doesn't have to be a " foreman", just someone else
on the team.
Post by Joe Bowbeer
I agree that crappy code is widespread (especially regarding thread-safe
aspects and extensible construction). If the missing knowledge is
widespread in a team then things aren't going to improve, and furthermore,
any heroic efforts by consultants will quickly be worn away. So I can
certainly sympathize with the "where is the foreman" question. I think it's
a legitimate question to ask. If a team isn't producing the quality of code
that it needs to produce then some changes need to be made. A foreman or
gatekeeper is one approach.
Post by Scott Shipp
Has anyone seen the "Where is the foreman?" blog posts from Robert C.
Martin lately. What are your opinions about the idea that one person or a
small oligarchy should vet all code commits? Does anyone work in a
situation where this is actually the case? What is the experience like?
http://blog.8thlight.com/uncle-bob/2014/02/21/WhereIsTheForeman.html
http://blog.8thlight.com/uncle-bob/2014/02/23/OhForemanWhereArtThou.html
http://blog.8thlight.com/uncle-bob/2014/02/27/TheTrustSpectrum.html
Continue reading on narkive:
Loading...